Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Researcher headset with med/intel #3956

Merged
merged 3 commits into from
Jul 22, 2023

Conversation

AnuvKH
Copy link
Contributor

@AnuvKH AnuvKH commented Jul 20, 2023

About the pull request

Adds a researcher headset with both medbay and intel channels. Tested, no issues, one line of code. Good when asked to do so.

Explain why it's good for the game

Researchers and the Intelligence Officers have a lot of intermixed gameplay mechanics with limited communication abilities. Both roles do have access to the Medical channel but it's often filled with medical issues and can be overlooked. This would increase communication and make requests to help with intel/corpse retrieval easier on both parties.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Anuv
add: Added a headset to Researchers with the intel channel included
/:cl:

@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -2. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added the Feature Feature coder badge label Jul 20, 2023
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a custom research headset with a key that has intel instead, let me know if you need any help

@morrowwolf morrowwolf marked this pull request as draft July 22, 2023 08:13
@AnuvKH
Copy link
Contributor Author

AnuvKH commented Jul 22, 2023

Make a custom research headset with a key that has intel instead, let me know if you need any help

Done, tested, let me know if I missed anything.

@AnuvKH AnuvKH changed the title Adds an intel key to Research vendor Adds a Researcher headset with med/intel Jul 22, 2023
@morrowwolf morrowwolf marked this pull request as ready for review July 22, 2023 20:55
@morrowwolf morrowwolf added this pull request to the merge queue Jul 22, 2023
Merged via the queue into cmss13-devs:master with commit b7cbbd7 Jul 22, 2023
@github-actions
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-7). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions bot added a commit that referenced this pull request Jul 22, 2023
cm13-github added a commit that referenced this pull request Jul 22, 2023
@SupernovaXTS SupernovaXTS mentioned this pull request Aug 7, 2023
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2023
# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->
Gives CMO the ability to vend reagent scanner goggles. Some people that
play CMO focus on research more than medical in things like making stims
or corrupted Xenos. Also gives CMO intel radio, Similar in intent to
#3956 but for CMO. Easier communication between IOs and CMOs that are
doing research would be helpful.
# Explain why it's good for the game
If a CMO is helping research with making corrupted Xenos or general
research and someone has taken the spare reagent goggles from research
they have to ask a researcher to vend them one.
Giving CMO access to intel radio at Roundstart would improve QoL for
CMOs. As it stands the current situation if a CMO wants to help research
and needs intel access they have to ask req for an intel key.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/56845006/18d49250-1054-4d46-b542-a0537cb9eb31)

Tested in local dev server
Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl: Megastar1234
add: Adds reagent scanner goggles to CMO vendor
add: Gives CMO headset intel radio
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants